Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credentials intialization revealed by mypy version of google auth #40108

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jun 7, 2024


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 7, 2024
@potiuk potiuk requested review from shahar1, Taragolis and eladkal June 7, 2024 05:25
@potiuk potiuk added the upgrade to newer dependencies If set, upgrade to newer dependencies is forced label Jun 7, 2024
@potiuk potiuk closed this Jun 7, 2024
@potiuk potiuk reopened this Jun 7, 2024
@potiuk
Copy link
Member Author

potiuk commented Jun 7, 2024

Triggered upgrade to newer deps.

@potiuk potiuk force-pushed the fix-mypy-errors-revealed-by-google-auth branch from 5843f41 to 679fd77 Compare June 7, 2024 05:53
@potiuk
Copy link
Member Author

potiuk commented Jun 7, 2024

There was one more error (and this time it was bug in google provider detected by mypy 🚀

@potiuk potiuk changed the title Fix mypy errors revealed by 2.30.0 version of google auth Fix credentials intialization revealed by mypy version of google auth Jun 7, 2024
@potiuk potiuk merged commit 013523e into apache:main Jun 7, 2024
57 of 58 checks passed
@potiuk potiuk deleted the fix-mypy-errors-revealed-by-google-auth branch June 7, 2024 06:19
utkarsharma2 pushed a commit that referenced this pull request Jul 3, 2024
@utkarsharma2 utkarsharma2 added this to the Airflow 2.9.3 milestone Jul 8, 2024
@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 8, 2024
utkarsharma2 pushed a commit that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) provider:google Google (including GCP) related issues upgrade to newer dependencies If set, upgrade to newer dependencies is forced
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants