Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-3177] Change scheduler_heartbeat from gauge to counter #4027

Merged
merged 2 commits into from
Oct 12, 2018
Merged

[AIRFLOW-3177] Change scheduler_heartbeat from gauge to counter #4027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85dcb95
[AIRFLOW-3177] Change scheduler_heartbeat from gauge to counter
schnie Oct 9, 2018
26f1d41
[AIRFLOW-3177] Add statsd change notice in UPDATING.md
schnie Oct 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,10 @@ To delete a user:
airflow users --delete --username jondoe
```

### StatsD Metrics

The `scheduler_heartbeat` metric has been changed from a gauge to a counter. Each loop of the scheduler will increment the counter by 1. This provides a higher degree of visibility and allows for better integration with Prometheus using the [StatsD Exporter](https://github.com/prometheus/statsd_exporter). Scheduler upness can be determined by graphing and alerting using a rate. If the scheduler goes down, the rate will drop to 0.

### Custom auth backends interface change

We have updated the version of flask-login we depend upon, and as a result any
Expand Down
2 changes: 1 addition & 1 deletion airflow/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,7 +1895,7 @@ def process_file(self, file_path, pickle_dags=False, session=None):

@provide_session
def heartbeat_callback(self, session=None):
Stats.gauge('scheduler_heartbeat', 1, 1)
Stats.incr('scheduler_heartbeat', 1, 1)


class BackfillJob(BaseJob):
Expand Down