Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replace parameter for BigQueryToPostgresOperator #40278

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

e-galan
Copy link
Contributor

@e-galan e-galan commented Jun 17, 2024

Add a required missing parameter replace_index to BigQueryToPostgresOperator and documentation explaining how to use the operator when the replace parameter is set to True.

Fixes a problem where it was impossible to run BigQueryToPostgresOperator because of the underlying PostgresHook._generate_insert_sql() method that required both selected_fields and replace_index parameters to be set if the replace parameter was True.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@e-galan e-galan force-pushed the fix-bigquery-to-postgres-upsert branch from f9b463b to d120df5 Compare June 17, 2024 12:31
@e-galan e-galan marked this pull request as draft June 17, 2024 12:32
@e-galan e-galan force-pushed the fix-bigquery-to-postgres-upsert branch from d120df5 to 3e4848d Compare June 18, 2024 08:19
@e-galan e-galan marked this pull request as ready for review June 18, 2024 11:24
@e-galan e-galan force-pushed the fix-bigquery-to-postgres-upsert branch from 3e4848d to 5163eef Compare June 18, 2024 12:43
@e-galan e-galan force-pushed the fix-bigquery-to-postgres-upsert branch from 5163eef to 40cbb63 Compare June 19, 2024 09:49
@VladaZakharova
Copy link
Contributor

Hi @potiuk @eladkal @Lee-W !
Can you please check changes here? Thanks! :)

@potiuk potiuk merged commit ca7e2a0 into apache:main Jun 20, 2024
51 checks passed
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants