Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Make sure xcoms work correctly in MSGraphAsyncOperator with concurrent workers #40297

Merged
merged 3 commits into from
Jun 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 22 additions & 14 deletions airflow/providers/microsoft/azure/operators/msgraph.py
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,10 @@ def execute_complete(
event["response"] = result

try:
self.trigger_next_link(response, method_name=self.pull_execute_complete.__name__)
self.trigger_next_link(response=response, method_name=self.execute_complete.__name__)
except TaskDeferred as exception:
self.results = self.pull_xcom(context=context)
self.log.debug("value: %s", result)
self.append_result(
result=result,
append_result_as_list_if_absent=True,
Expand All @@ -198,8 +200,6 @@ def append_result(
result: Any,
append_result_as_list_if_absent: bool = False,
):
self.log.debug("value: %s", result)

if isinstance(self.results, list):
if isinstance(result, list):
self.results.extend(result)
Expand All @@ -214,30 +214,38 @@ def append_result(
else:
self.results = result

def push_xcom(self, context: Context, value) -> None:
self.log.debug("do_xcom_push: %s", self.do_xcom_push)
if self.do_xcom_push:
self.log.info("Pushing XCom with key '%s': %s", self.key, value)
self.xcom_push(context=context, key=self.key, value=value)
def xcom_key(self, context: Context) -> str:
map_index = context["ti"].map_index
return f"{self.key}_{map_index}" if map_index else self.key

def pull_execute_complete(self, context: Context, event: dict[Any, Any] | None = None) -> Any:
self.results = list(
def pull_xcom(self, context: Context) -> list:
key = self.xcom_key(context=context)
value = list(
self.xcom_pull(
context=context,
task_ids=self.task_id,
dag_id=self.dag_id,
key=self.key,
key=key,
)
or []
)

self.log.info(
"Pulled XCom with task_id '%s' and dag_id '%s' and key '%s': %s",
self.task_id,
self.dag_id,
self.key,
self.results,
key,
value,
)
return self.execute_complete(context, event)

return value

def push_xcom(self, context: Context, value) -> None:
self.log.debug("do_xcom_push: %s", self.do_xcom_push)
if self.do_xcom_push:
key = self.xcom_key(context=context)
self.log.info("Pushing XCom with key '%s': %s", key, value)
self.xcom_push(context=context, key=key, value=value)

@staticmethod
def paginate(operator: MSGraphAsyncOperator, response: dict) -> tuple[Any, dict[str, Any] | None]:
Expand Down