Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to toggle the unfurl behavior for slack notifier #40694

Merged

Conversation

armand-sauzay
Copy link
Contributor

Enable toggling the unfurling of media and URLs for the SlackNotifier.

In order to not unfurl media and have alerts messages that are shorter than the unfurling, enable toggling that behavior.

Happy to hear if there are better ways to handle this, thanks!


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk merged commit c25858c into apache:main Jul 10, 2024
55 checks passed
Copy link

boring-cyborg bot commented Jul 10, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@armand-sauzay armand-sauzay deleted the feat/add-unfurl-options-to-slack-notifier branch July 11, 2024 00:32
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants