-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor dataproc system tests #40720
Conversation
Some static checks. As usuall - I recommend to have pre-commit installed, it fixes all those problems automatically :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall - static checks should be fixed as Jarek mentioned.
Also, I assume that there was a reason for changing the regions in the system tests - is there any policy for that? (I think that it should be mentioned somwhere)
6ad0951
to
bf35f93
Compare
@potiuk @shahar1 hi! thank you for checking this one. Changes in regions and locations were made only to fix the problem in our Composer CI: with previous setup there was a big load on one specific region that was used in all of them. This PR fixes this, but the rest in the test remains the same. |
In this pre-commit:
Just have a `>> watcher()`` check instead of the full append instructions |
bf35f93
to
c11f22f
Compare
c11f22f
to
eaa61b1
Compare
eaa61b1
to
0a4fad4
Compare
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.