Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated TaskMixin class #41394

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 12, 2024

The airflow.models.taskMixin.TaskMixin class has been removed. It was previously deprecated in favor of the airflow.models.taskMixin.DependencyMixin class.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@kaxil kaxil requested review from XD-DENG and ashb as code owners August 12, 2024 00:34
@kaxil kaxil added the airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes label Aug 12, 2024
@kaxil kaxil added this to the Airflow 3.0.0 milestone Aug 12, 2024
@kaxil kaxil requested a review from Lee-W August 12, 2024 01:17
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If TaskMixin is removed, should we update the comments in

"""Required by TaskMixin."""
as well?

The ``airflow.models.taskMixin.TaskMixin`` class has been removed. It was previously
deprecated in favor of the ``airflow.models.taskMixin.DependencyMixin`` class.
@kaxil kaxil force-pushed the remove-taskmixin branch from 1bb0854 to 34b9d2f Compare August 12, 2024 01:51
@kaxil kaxil requested a review from uranusjr as a code owner August 12, 2024 01:51
@kaxil
Copy link
Member Author

kaxil commented Aug 12, 2024

If TaskMixin is removed, should we update the comments in

"""Required by TaskMixin."""

as well?

Done

@kaxil kaxil merged commit 61a181f into apache:main Aug 12, 2024
49 checks passed
@kaxil kaxil deleted the remove-taskmixin branch August 12, 2024 02:31
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Aug 20, 2024
The ``airflow.models.taskMixin.TaskMixin`` class has been removed. It was previously
deprecated in favor of the ``airflow.models.taskMixin.DependencyMixin`` class.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airflow3.0:breaking Candidates for Airflow 3.0 that contain breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants