-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Airflow 3: python operators deprecations removal #41493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to wait with breaking changes to core operators/sensors
See
https://lists.apache.org/thread/2dmlqkcmyomm4q7rrovygs6bw655zx07
Are we planning to introduce new provider in Airflow 3? |
But... @eladkal we shoudl "clean-up" before carrying the legacy to new operators.. or? In my eyes we shoudl not carry-over deprecations. |
Newsfragment is missing though :-D Please add... |
Added the news fragment for this change. |
|
@@ -0,0 +1 @@ | |||
Removed deprecated method ``task`` from ``airflow.operators.python`` operator. Please use ``python_task`` from ``airflow.decorators.python`` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newsfragment will be about removing all the classses in the file.
This specific removal you are referring to will be in provider breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will have to keep it in newsfragments, so far those were "core" operators - and we have not moved them to "provider.standard" yet - and as I understand that, the standard provider will be part of the Airflow 3 migration (we will not remove old Python operators from Airflow 2 - we will add deprecation there) so the newsfragment should be still in Airflow - I think.
I see two other deprecations in python.py - can you also remove these in the scope of the PR? |
I have added the news fragment. |
Serialization code refactoring changes added recently (may be 2.10). Does it make sense to remove them immediately? |
Deprecated is deprecated I'd say. It is by warning announced to be gone. Even if it is just announced in 2.10, this means 6+ months of notice before release. As well if we not remove in 3.0, then we would need to carry until 4.0 |
Yes. However, I want to reconfirm once before making the changes. |
I think we need to wait for next dev call where we discuss "standard" provider's scope |
39a6e45
to
168bdcf
Compare
Any update on this? |
No - not really - there is another change in progress - #42081 that moves Python operators to "standard" providers, and I think what you did here should be done as part of it, rather than separate PR from you - so I think the best course of action is to close that one and get you @dirrao to review and make comment in the #42081 so that we make sure deprecations are removed in the standard provider. This should be generally done in the same way for all operators that are part of the "core" - we should move all of them to " "standard" and remove the deprecation "along the way". cc: @gopidesupavan. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
Airflow 3: python operators deprecations removal