-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-3343] Update DockerOperator for Docker-py 3.0.0 API changes #4187
Conversation
9314e01
to
bf81bd5
Compare
@XD-DENG PTAL - this was the bug I pinged you about in slack. |
Codecov Report
@@ Coverage Diff @@
## master #4187 +/- ##
========================================
Coverage ? 77.7%
========================================
Files ? 199
Lines ? 16303
Branches ? 0
========================================
Hits ? 12669
Misses ? 3634
Partials ? 0
Continue to review full report at Codecov.
|
bf81bd5
to
b2bd2c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor Changes, LGTM otherwise.
The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
b2bd2c6
to
fff2a53
Compare
…4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
…pache#4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
…4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
…pache#4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
…pache#4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
…4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
…pache#4187) The API of `wait()` changed to return a dict, not just a number so this Operator wasn't actually working, but the tests were passing because the return was mocked in-correctly. I also removed `shm_size` from kwargs passed to BaseOperator to avoid the deprecation warning about unknown args.
Make sure you have checked all steps below.
Jira
Description
wait()
changed to return a dict, not just a number so thisOperator wasn't actually working, but the tests were passing because the
return was mocked in-correctly.
Since it appears that the python Docker module follows semver, with breaking changes only on major versions I have also changed the format specifier so we don't pull in 4.0.0 accidentally in the future.
I also removed
shm_size
from kwargs passed to BaseOperator to avoidthe deprecation warning about unknown args.
Tests
Commits
Documentation
Code Quality
flake8