fix(migration): fix dataset to asset migration typo #43245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
fix-dataset-to-asset-migration-typo
branch
from
c6413e0 to
e658a93
Compare
Lee-W
force-pushed
the
fix-dataset-to-asset-migration-typo
branch
3 times, most recently
from
db96b28 to
7365f9c
Compare
|
Why is it Also running |
Those are fks from Airflow 2.10 that we need to rename.
Thanks for reminding me! There's yet another issue, but somewhat related. Fixed in this PR |
Lee-W
force-pushed
the
fix-dataset-to-asset-migration-typo
branch
from
7365f9c to
bf2fa09
Compare
uranusjr
approved these changes
Oct 23, 2024
0026 yes, 0040 no |
…g_fkey. thus, we need to use dsdar_dag_fkey in migration files
Lee-W
force-pushed
the
fix-dataset-to-asset-migration-typo
branch
from
bf2fa09 to
628fcf9
Compare
|
backport pr #43314 |
harjeevanmaan
pushed a commit
to harjeevanmaan/airflow
that referenced
this pull request
Oct 23, 2024
* fix(migration): fix dataset to asset migration typo * fix(migrations): dsdar_dag_id_fkey was accidentally named as dsdar_dag_fkey. thus, we need to use dsdar_dag_fkey in migration files
PaulKobow7536
pushed a commit
to PaulKobow7536/airflow
that referenced
this pull request
Oct 24, 2024
* fix(migration): fix dataset to asset migration typo * fix(migrations): dsdar_dag_id_fkey was accidentally named as dsdar_dag_fkey. thus, we need to use dsdar_dag_fkey in migration files
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
* fix(migration): fix dataset to asset migration typo * fix(migrations): dsdar_dag_id_fkey was accidentally named as dsdar_dag_fkey. thus, we need to use dsdar_dag_fkey in migration files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #43226
Why
dsdar_dataset_alias_fkeywas accidentally named asdsdar_dataset_fkeyin migration files^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.