Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AIP-74 migration errors #43313

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix AIP-74 migration errors #43313

merged 2 commits into from
Oct 24, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Oct 23, 2024

Why

I have conducted further testing on migrating between versions and discovered some typos and errors.

What

  • fix(migrations):
    • add server_default to the newly added "group" column in the dataset table
      • without this change, db with existing dataset rows break due to nullable=False
    • fix typos in the dataset to asset migration files and model

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W requested review from XD-DENG and ashb as code owners October 23, 2024 13:55
@boring-cyborg boring-cyborg bot added the area:db-migrations PRs with DB migration label Oct 23, 2024
@Lee-W Lee-W force-pushed the fix-migration-typo branch from 39a5eae to 001399c Compare October 23, 2024 13:56
@Lee-W Lee-W requested review from uranusjr and removed request for ashb and XD-DENG October 23, 2024 13:57
@Lee-W Lee-W added the AIP-74 Dataset -> Asset label Oct 23, 2024
@Lee-W Lee-W mentioned this pull request Oct 23, 2024
2 tasks
@Lee-W Lee-W force-pushed the fix-migration-typo branch from 001399c to 4e7c25f Compare October 23, 2024 14:42
@Lee-W Lee-W requested a review from potiuk as a code owner October 23, 2024 14:42
Lee-W added 2 commits October 24, 2024 08:37
… in the dataset table

without this change, db with existing dataset rows break due to nullable=False
@Lee-W Lee-W force-pushed the fix-migration-typo branch from 4e7c25f to 0ba17e6 Compare October 24, 2024 00:37
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic ... Getting things better reviewed and tested piece-by-piece

@potiuk potiuk merged commit 06da35c into apache:main Oct 24, 2024
52 checks passed
@ashb ashb deleted the fix-migration-typo branch October 24, 2024 15:24
ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
* fix(migrations): fix typos in the dataset to asset migration files and model

* fix(migrations): add server_default to the newly added "group" column in the dataset table

without this change, db with existing dataset rows break due to nullable=False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-74 Dataset -> Asset area:db-migrations PRs with DB migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants