Change default value of namespace in task.kubernetes to be None
#43402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
eladkal
reviewed
Oct 26, 2024
providers/src/airflow/providers/cncf/kubernetes/decorators/kubernetes.py
Show resolved
Hide resolved
romsharon98
requested review from
jedcunningham and
hussein-awala
as code owners
amoghrajesh
reviewed
Nov 1, 2024
eladkal
reviewed
Nov 1, 2024
romsharon98
force-pushed
the
fix/k8s-decorator-and-operator-namespace
branch
from
ea77718 to
086e5c9
Compare
romsharon98
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
jscheffl
as code owners
romsharon98
force-pushed
the
fix/k8s-decorator-and-operator-namespace
branch
from
8458723 to
756a5ea
Compare
eladkal
approved these changes
Nov 5, 2024
amoghrajesh
approved these changes
Nov 5, 2024
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…pache#43402) * change default namespace value to be None * passing namespace to decorator when in_cluster=False * add breaking change * change changelog * revert ui change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #42957
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.