GlueJobOperator: add option to wait for cleanup before returning job status #43688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
approved these changes
Nov 5, 2024
romsharon98
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes to solve a bug around the case of concurrency=1. In that scenario Glue returns final state before actually cleaning up the resources. This leads to a problem we can have more than 1 concurrent job in Glue.
To avoid this and according to AWS recommendation adding the option to wait (5-10) seconds before returning the job status
Not sure how to test this one (if we need testing for this at all?).
It just adds sleep before returning the final status