AIP-72: Port task success overtime to the Supervisor #44590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
added
the
area:task-execution-interface-aip72
kaxil
force-pushed
the
add-overtime
branch
6 times, most recently
from
1d0afab to
4be85f7
Compare
ashb
reviewed
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
kaxil
commented
Dec 3, 2024
ashb
reviewed
Dec 3, 2024
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closes apache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
ashb
reviewed
Dec 3, 2024
ashb
approved these changes
Dec 3, 2024
LefterisXefteris
pushed a commit
to LefterisXefteris/airflow
that referenced
this pull request
Jan 5, 2025
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closes apache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This PR ports the overtime feature on `LocalTaskJob` (added in apache#39890) to the Supervisor. It allows to terminate Task process to terminate when it exceeding the configured success overtime threshold which is useful when we add Listenener to the Task process. closes apache#44356 Also added `TaskState` to update state and send end_date from task process to the supervisor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the overtime feature on
LocalTaskJob(added in #39890) to the Supervisor. It allows the Task process to terminate when it is exceeding the configured overtime threshold which is useful when we add Listenener to the Task process.The overtime configured here applies to all states not just success, as was the case with LTJ.
closes #44356
Also added
TaskStateto update state and send end_date from task process to the supervisor.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.