Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tries disappearing when first try is selected out of multiple tries. #45206

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Fix tries disappearing when first try is selected out of multiple tries. #45206

merged 1 commit into from
Dec 25, 2024

Conversation

tirkarthi
Copy link
Contributor

Check for taskInstance.try_number to show tries instead of current selected tryNumber that makes other tries to disappear on selection of first try.

To reproduce :

  1. Go to a task instance with multiple tries.
  2. Select the first try and the tries component disappears.

@tirkarthi
Fix tries disappearing when first try is selected out of multiple tries.
b30df87 
Check for taskInstance.try_number to show tries instead of current selected tryNumber
that makes other tries to disappear on selection of first try.
@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Dec 25, 2024
jscheffl
jscheffl approved these changes Dec 25, 2024
View reviewed changes
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! That works!

@jscheffl jscheffl merged commit 2bb13c7 into apache:main Dec 25, 2024
41 checks passed
LefterisXefteris pushed a commit to LefterisXefteris/airflow that referenced this pull request Jan 5, 2025
@tirkarthi
Fix tries disappearing when first try is selected out of multiple tri…
53da9ba 
…es. (apache#45206)

Check for taskInstance.try_number to show tries instead of current selected tryNumber
that makes other tries to disappear on selection of first try.
agupta01 pushed a commit to agupta01/airflow that referenced this pull request Jan 6, 2025
@tirkarthi @agupta01
Fix tries disappearing when first try is selected out of multiple tri…
69658f6 
…es. (apache#45206)

Check for taskInstance.try_number to show tries instead of current selected tryNumber
that makes other tries to disappear on selection of first try.
HariGS-DB pushed a commit to HariGS-DB/airflow that referenced this pull request Jan 16, 2025
@tirkarthi @HariGS-DB
Fix tries disappearing when first try is selected out of multiple tri…
d5faea0 
…es. (apache#45206)

Check for taskInstance.try_number to show tries instead of current selected tryNumber
that makes other tries to disappear on selection of first try.
got686-yandex pushed a commit to got686-yandex/airflow that referenced this pull request Jan 30, 2025
@tirkarthi @got686-yandex
Fix tries disappearing when first try is selected out of multiple tri…
e18b452 
…es. (apache#45206)

Check for taskInstance.try_number to show tries instead of current selected tryNumber
that makes other tries to disappear on selection of first try.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@pierrejeambrun pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

Assignees
No one assigned
Labels
area:UI Related to UI/UX. For Frontend Developers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirkarthi @jscheffl