Incorrect field rendering in DAG Params #45574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
|
Even after removing the condition, validations are happening. |
rawwar
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
jscheffl
requested changes
Jan 11, 2025
There was a problem hiding this comment.
Handling of non string types array was added as a feature some time ago.
I don't see this as a "bug" and forcing users to enter a list of strings in JSON is something that I would very mus dis-like.
New features in this area and improvements for more options can be added in 3.x, but in 2.10-line we should keep it like it is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45290