Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LoggingMixin for DagProcessorManager #46408

Merged

Conversation

jedcunningham
Copy link
Member

Since we always have a standalone DAG processor now, we no longer need the special logging config to have a separate log file for the DagProcessorManager. Using LoggingMixin instead, all of the logs end up on stdout, just like other Airflow components.

This also adds the ability to have a "non deprecated" removal in config lint:

Screenshot 2025-02-03 at 11 13 08 PM

Since we always have a standalone DAG processor now, we no longer need
the special logging config to have a separate log file for the
DagProcessorManager. Using LoggingMixin instead, all of the logs end up
on stdout, just like other Airflow components.
@jedcunningham jedcunningham force-pushed the refactor_dag_processor_logging branch from 93c8329 to 710639a Compare February 4, 2025 06:23
@jedcunningham jedcunningham added AIP-66: DAG Bundle/Manifest full tests needed We need to run full set of tests for this PR to merge labels Feb 4, 2025
@jedcunningham jedcunningham reopened this Feb 4, 2025
@jedcunningham jedcunningham merged commit 7190cb2 into apache:main Feb 4, 2025
91 checks passed
@jedcunningham jedcunningham deleted the refactor_dag_processor_logging branch February 4, 2025 21:24
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
Since we always have a standalone DAG processor now, we no longer need
the special logging config to have a separate log file for the
DagProcessorManager. Using LoggingMixin instead, all of the logs end up
on stdout, just like other Airflow components.
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
Since we always have a standalone DAG processor now, we no longer need
the special logging config to have a separate log file for the
DagProcessorManager. Using LoggingMixin instead, all of the logs end up
on stdout, just like other Airflow components.
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Since we always have a standalone DAG processor now, we no longer need
the special logging config to have a separate log file for the
DagProcessorManager. Using LoggingMixin instead, all of the logs end up
on stdout, just like other Airflow components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

3 participants