Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/edge worker restarts on version mismatch #46453

Conversation

majorosdonat
Copy link
Contributor

@majorosdonat majorosdonat commented Feb 5, 2025

As the edge worker does not use internal api anymore, we need to handle the EdgeWorkerVersionException when http 400 is raised


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Majoros Donat (XC-DX/EET2-Bp) added 2 commits February 4, 2025 15:58
@boring-cyborg boring-cyborg bot added the provider:edge Edge Executor / Worker (AIP-69) label Feb 5, 2025
@majorosdonat majorosdonat marked this pull request as ready for review February 5, 2025 08:48
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and... uuups thanks for fixing the glitches introduced by refactoring to FastAPI!

@jscheffl jscheffl merged commit 0a61ac8 into apache:main Feb 5, 2025
70 of 102 checks passed
insomnes pushed a commit to insomnes/airflow that referenced this pull request Feb 6, 2025
* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* add exception messgae

* Increment version

* change misc to fix

---------

Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]>
niklasr22 pushed a commit to niklasr22/airflow that referenced this pull request Feb 8, 2025
* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* add exception messgae

* Increment version

* change misc to fix

---------

Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]>
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* Raise custom exception

* fix static checks

* add exception messgae

* Increment version

* change misc to fix

---------

Co-authored-by: Majoros Donat (XC-DX/EET2-Bp) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:edge Edge Executor / Worker (AIP-69)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants