Fix bug in query invalidation and remove custom predicate logic #46485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
jscheffl
approved these changes
Feb 5, 2025
pierrejeambrun
approved these changes
Feb 5, 2025
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
…he#46485) * Fix bug in query invalidation and remove custom predicate logic * Address PR feedback * Only use key fn when we have props to pass
insomnes
pushed a commit
to insomnes/airflow
that referenced
this pull request
Feb 6, 2025
…he#46485) * Fix bug in query invalidation and remove custom predicate logic * Address PR feedback * Only use key fn when we have props to pass
niklasr22
pushed a commit
to niklasr22/airflow
that referenced
this pull request
Feb 8, 2025
…he#46485) * Fix bug in query invalidation and remove custom predicate logic * Address PR feedback * Only use key fn when we have props to pass
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…he#46485) * Fix bug in query invalidation and remove custom predicate logic * Address PR feedback * Only use key fn when we have props to pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was passing
{ dagIds: [dagId] }instead of{dagId}touseDagRunServiceGetDagRunsKeyand that is why the query wasn't invalidating correct.y We actually didn't need all the custom query matching logic^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.