Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4901] Relaxes jinja2 version requirement #5556

Closed
wants to merge 1 commit into from

Conversation

purew
Copy link

@purew purew commented Jul 10, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • Fixes https://issues.apache.org/jira/browse/AIRFLOW-4901
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Relaxes jinja version requirement so that pipenv can install airflow.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    PR merely relaxes a jinja version constraint.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@purew purew force-pushed the relax-requirements branch from 10c2162 to ee5caf8 Compare July 10, 2019 17:30
@purew purew changed the title Relaxes jinja2 version requirement [AIRFLOW-4901] Relaxes jinja2 version requirement Jul 10, 2019
@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #5556 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #5556   +/-   ##
======================================
  Coverage      79%     79%           
======================================
  Files         489     489           
  Lines       30726   30726           
======================================
  Hits        24275   24275           
  Misses       6451    6451

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f9d9a...ee5caf8. Read the comment docs.

@pgagnon
Copy link
Contributor

pgagnon commented Jul 11, 2019

@ashb

@ashb
Copy link
Member

ashb commented Jul 11, 2019

2.10.1 is a security fix on 2.10.0 so no, afraid not. - https://github.com/pallets/jinja/blob/master/CHANGES.rst#version-2101

@ashb ashb closed this Jul 11, 2019
@pgagnon
Copy link
Contributor

pgagnon commented Jul 11, 2019

@purew Are you able to find a way to fix this further down the dependency graph? This is problematic. 😕

@ashb
Copy link
Member

ashb commented Jul 12, 2019

See also pypa/pipenv#2596 - the dependency solver in pipenv isn't without it's problems and that might be what is happening here.

@purew
Copy link
Author

purew commented Jul 12, 2019

@pgagnon We're running airflow inside a secure environment so I wont dig deeper into this. I'll use this fork and the insecure jinja version until it's been solved upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants