-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6792] Remove _operator/_hook/_sensor in providers package and add tests #7412
Conversation
9a0d9e7
to
1f5d6ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
..but why not just aws
/ google
? If we want to prefix it with base_
I would suggest to rename the class name also to BaseAwsHook
. WDYT?
This is too confusing because we also have packages that have the same name.
We currently have CloudBaseHook class, so maybe let's call AwsBaseHook and GoogleBaseHook. WDYT? |
I am fine with this 👍 |
…kage and add tests
…ers package and add tests
65387d4
to
81114be
Compare
… providers package and add tests
…nsor in providers package and add tests
Hello,
I fixed small inconsistencies and added tests to avoid regression.
Best regards,
Kamil
@feluelle I also renamed aws_hook to base_aws. WDYT? In separate PR. I will rename airflow.providers.google.cloud.base to airflow.providers.google.common.base_google to unify names.
Issue link: AIRFLOW-6792
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.