Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6792] Remove _operator/_hook/_sensor in providers package and add tests #7412

Merged
merged 5 commits into from
Feb 17, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Feb 13, 2020

Hello,

I fixed small inconsistencies and added tests to avoid regression.

Best regards,
Kamil

@feluelle I also renamed aws_hook to base_aws. WDYT? In separate PR. I will rename airflow.providers.google.cloud.base to airflow.providers.google.common.base_google to unify names.


Issue link: AIRFLOW-6792

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added provider:Apache provider:amazon AWS/Amazon - related issues labels Feb 13, 2020
@mik-laj mik-laj requested a review from feluelle February 14, 2020 07:37
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

..but why not just aws / google ? If we want to prefix it with base_ I would suggest to rename the class name also to BaseAwsHook. WDYT?

@mik-laj
Copy link
Member Author

mik-laj commented Feb 17, 2020

..but why not just `aws / google ?

This is too confusing because we also have packages that have the same name.

If we want to prefix it with base_ I would suggest to rename the class name also to BaseAwsHook. WDYT?

We currently have CloudBaseHook class, so maybe let's call AwsBaseHook and GoogleBaseHook. WDYT?

@feluelle
Copy link
Member

We currently have CloudBaseHook class, so maybe let's call AwsBaseHook and GoogleBaseHook. WDYT?

I am fine with this 👍

Kamil Breguła added 2 commits February 17, 2020 22:53
@codecov-io
Copy link

codecov-io commented Feb 17, 2020

Codecov Report

Merging #7412 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #7412     +/-   ##
=========================================
- Coverage   86.66%   86.37%   -0.3%     
=========================================
  Files         878      877      -1     
  Lines       41219    41221      +2     
=========================================
- Hits        35722    35603    -119     
- Misses       5497     5618    +121
Impacted Files Coverage Δ
...ow/providers/docker/example_dags/example_docker.py 100% <ø> (ø)
...w/providers/apache/pig/example_dags/example_pig.py 100% <ø> (ø)
...viders/docker/example_dags/example_docker_swarm.py 100% <ø> (ø)
.../providers/google/suite/operators/gcs_to_gdrive.py 100% <ø> (ø)
...irflow/providers/http/example_dags/example_http.py 100% <ø> (ø)
...cncf/kubernetes/example_dags/example_kubernetes.py 78.57% <ø> (ø)
...providers/google/cloud/example_dags/example_dlp.py 100% <ø> (ø)
...low/providers/yandex/hooks/yandexcloud_dataproc.py 100% <ø> (ø)
.../cloud/operators/cloud_storage_transfer_service.py 95.63% <100%> (ø) ⬆️
...flow/providers/amazon/aws/hooks/lambda_function.py 100% <100%> (ø) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b199cb...8344222. Read the comment docs.

@mik-laj mik-laj merged commit 9cbd7de into apache:master Feb 17, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
provider:amazon AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants