Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out metastore_browser from airflow.contrib #9341

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jun 16, 2020

Formerly the core code was maintained by the original creators - Airbnb. The code that was in the contrib package was supported by the community. The project was passed to the Apache community and currently the entire code is maintained by the community, so now the division has no justification, and it is only due to historical reasons.

We plan to deprecate the airflow.contrib package. Unfortunately, there are still a few modules left that block it.

In addition, I wrote a short README. which describes how to install this plugin. In the future, we can add more text to this file if we decide to develop this plugin

It's not breaking change, because this plugin was not automatically installed. Anyone who wanted to install it had to manually copy these files to plugin directory. We also did not mention this plugin in any documentation. We did not actively develop it, but rather treated it as an example plugin.


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member

potiuk commented Jun 17, 2020

You need to include "metastore_browser" in .dockerignore. By default we are excluding everything in .dockerignore and only include what we need (that's the best practice for Dockerignore - makes context to send much smaller when you have a lot of automatically generated artifacts in sources - which we have)

@mik-laj mik-laj force-pushed the contrib-metastore branch from 99a85b6 to 824ee9d Compare June 17, 2020 10:37
@mik-laj mik-laj requested a review from potiuk June 17, 2020 17:14
@mik-laj mik-laj changed the title Move out metastore_browser from airflow plugins Move out metastore_browser from airflow.contrib Jun 17, 2020
@mik-laj mik-laj merged commit 6a9c436 into apache:master Jun 17, 2020
@mik-laj mik-laj deleted the contrib-metastore branch June 17, 2020 19:52
kaxil pushed a commit to kaxil/airflow that referenced this pull request Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants