Helm Docker image sources are now included in the Airlfow codebase #9650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
add-helm-dockerfiles
branch
4 times, most recently
from
43e6406 to
59b8a70
Compare
potiuk
force-pushed
the
add-helm-dockerfiles
branch
from
59b8a70 to
bbb3bd5
Compare
|
Hey @dimberman @schnie - I'd love your review on that - see the email! |
Closed
potiuk
force-pushed
the
add-helm-dockerfiles
branch
from
bbb3bd5 to
052f94a
Compare
We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of apache#9401
potiuk
force-pushed
the
add-helm-dockerfiles
branch
from
052f94a to
51b53d0
Compare
|
@kaxil @dimberman @schnie -> I rebased the change where I made all the images used by Helm part of our sources. They are green - and all the sources are easy to rebuild. I hope this will be ok for all of you finally. I basically re-created the images without copying the original sources, and all the builds scripts and labelling scheme is consistent. Do you still have any reservation against this? If so - can we talk about it and resolve it ? |
kaxil
approved these changes
Aug 25, 2020
|
Apologies on not seeing this one earlier. I see no problem with this one, approved |
|
Coool! Thanks @kaxil ! Much appreciated! I think this is an important step to release the helm charts! I am going to add some contributions soon. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 14, 2020
…pache#9650) We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of apache#9401 (cherry picked from commit c6e6d6d)
potiuk
added a commit
that referenced
this pull request
Sep 15, 2020
…9650) We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of #9401 (cherry picked from commit c6e6d6d)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
…pache#9650) We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of apache#9401 (cherry picked from commit c6e6d6d)
kaxil
pushed a commit
that referenced
this pull request
Nov 12, 2020
…9650) We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of #9401 (cherry picked from commit c6e6d6d)
potiuk
added
the
type:misc/internal
potiuk
added a commit
that referenced
this pull request
Nov 16, 2020
…9650) We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of #9401 (cherry picked from commit c6e6d6d)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…pache#9650) We can now build all the images from Airlfow sources in a reproducible fashion and our users can use the helm chart based on the images build from official images + code in Airflow Codebase. We also have consistent versioning scheme based on calver version of releasing the images coupled with the version of the original package. Part of apache#9401 (cherry picked from commit c6e6d6d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now build all the images from Airlfow sources in
a reproducible fashion and our users can use the helm chart
based on the images build from official images + code in
Airflow Codebase.
We also have consistent versioning scheme based on
calver version of releasing the images coupled with
the version of the original package.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.