Skip to content

Commit

Permalink
Fixed some unit test issues
Browse files Browse the repository at this point in the history
  • Loading branch information
zhoujinsong committed Feb 5, 2025
1 parent 0410465 commit b42c758
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,5 @@ public class InternalTableConstants {
public static final String OSS_PROTOCOL_PREFIX = "oss://";

public static final String CHANGE_STORE_TABLE_NAME_SUFFIX =
InternalMixedIcebergCatalog.CHANGE_STORE_SEPARATOR
+ MixedTable.CHANGE_STORE_IDENTIFIER
+ InternalMixedIcebergCatalog.CHANGE_STORE_SEPARATOR;
InternalMixedIcebergCatalog.CHANGE_STORE_SEPARATOR + MixedTable.CHANGE_STORE_IDENTIFIER;
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import org.apache.amoro.TableFormat;
import org.apache.amoro.shade.guava32.com.google.common.base.Preconditions;
import org.apache.amoro.shade.guava32.com.google.common.collect.Maps;
import org.apache.amoro.table.MixedTable;
import org.apache.amoro.table.PrimaryKeySpec;
import org.apache.amoro.table.TableMetaStore;
import org.apache.hadoop.conf.Configuration;
Expand Down Expand Up @@ -114,6 +115,13 @@ protected Table createChangeStore(
return tableMetaStore.doAs(() -> icebergCatalog.loadTable(changeIdentifier));
}

@Override
protected TableIdentifier generateChangeStoreIdentifier(TableIdentifier baseIdentifier) {
return TableIdentifier.of(
baseIdentifier.namespace(),
baseIdentifier.name() + CHANGE_STORE_SEPARATOR + MixedTable.CHANGE_STORE_IDENTIFIER);
}

/**
* The change store will be dropped automatically by AMS when dropping the base store, so we do
* nothing here
Expand Down

0 comments on commit b42c758

Please sign in to comment.