-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support stop all #3374
support stop all #3374
Conversation
Could you please align this PR with the Pull Request Guidelines? |
@ihadoop, thanks for the contribution. As @XBaith commented, please respect the Pull Request Guidelines. For the change, does it release the resources for the optimizers for the current change, or do we need to release the optimizers manually? Thanks. |
@ihadoop is there anything I can help here? maybe we can call the rest API to release the optimizers. |
want to support restarting all process . if we release optimizers when restart (stop-start) ams, when start optimizers? |
@ihadoop Currently we can stop all(including the optimizers) by calling the rest of the API in the shell script. But for restarting all, maybe we need to support automatic restart optimizers on the server side first. |
yes , argee with you . first , we can stop all which call stop-ams.sh and send stop command to local optimizers. |
Why are the changes needed?
Close #3328.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation