Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support stop all #3374

Closed
wants to merge 15 commits into from
Closed

Conversation

ihadoop
Copy link
Contributor

@ihadoop ihadoop commented Dec 19, 2024

Why are the changes needed?

Close #3328.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@klion26 klion26 self-requested a review December 20, 2024 02:21
@XBaith
Copy link
Contributor

XBaith commented Dec 20, 2024

Could you please align this PR with the Pull Request Guidelines?
This will ensure it meets the project's standards and is easier to review.

@klion26
Copy link
Member

klion26 commented Dec 23, 2024

@ihadoop, thanks for the contribution. As @XBaith commented, please respect the Pull Request Guidelines.

For the change, does it release the resources for the optimizers for the current change, or do we need to release the optimizers manually? Thanks.

@klion26
Copy link
Member

klion26 commented Jan 3, 2025

@ihadoop is there anything I can help here? maybe we can call the rest API to release the optimizers.

@ihadoop
Copy link
Contributor Author

ihadoop commented Jan 3, 2025

@ihadoop is there anything I can help here? maybe we can call the rest API to release the optimizers.

want to support restarting all process . if we release optimizers when restart (stop-start) ams, when start optimizers?

@klion26
Copy link
Member

klion26 commented Jan 7, 2025

@ihadoop Currently we can stop all(including the optimizers) by calling the rest of the API in the shell script. But for restarting all, maybe we need to support automatic restart optimizers on the server side first.

@ihadoop
Copy link
Contributor Author

ihadoop commented Jan 9, 2025

@ihadoop Currently we can stop all(including the optimizers) by calling the rest of the API in the shell script. But for restarting all, maybe we need to support automatic restart optimizers on the server side first.

yes , argee with you . first , we can stop all which call stop-ams.sh and send stop command to local optimizers.

@github-actions github-actions bot added module:ams-server Ams server module and removed type:build labels Jan 12, 2025
@ihadoop ihadoop changed the title restart & stop shell script support stop all Jan 12, 2025
@ihadoop ihadoop closed this Jan 12, 2025
@ihadoop ihadoop deleted the stop_optimizer_when_stop_ams branch January 13, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support to stop/restart the optimizers when stop/restart the ams server
3 participants