Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3420] Fix info-level log message printing issue #3432

Merged
merged 3 commits into from
Feb 8, 2025
Merged

[AMORO-3420] Fix info-level log message printing issue #3432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
222798e
Do not set log level in codes
zhoujinsong Feb 7, 2025
33e4627
Fix log4j2.xml format
zhoujinsong Feb 7, 2025
39df82f
Merge branch 'master' into fix-ams-logger
zhoujinsong Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion amoro-ams/src/main/java/org/apache/amoro/server/terminal/local/LocalSessionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ protected synchronized SparkSession lazyInitContext() {
}

context = SparkSession.builder().config(sparkconf).getOrCreate();
context.sparkContext().setLogLevel("WARN");
}

return context;
Expand Down
6 changes: 4 additions & 2 deletions amoro-ams/src/main/resources/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,11 @@
<Loggers>
<Root level="debug">
<AppenderRef ref="consoleAppender" level="info"/>
<AppenderRef ref="consoleAppender" level="error"/>
</Root>
<Logger name="iceberg.metric" level="info">
<Logger name="org.apache.spark" additivity="false">
<AppenderRef ref="consoleAppender" level="warn"/>
</Logger>
<Logger name="iceberg.metric" level="info" additivity="false">
<AppenderRef ref="icebergRestMetricReporter"/>
</Logger>
</Loggers>
Expand Down
11 changes: 8 additions & 3 deletions dist/src/main/amoro-bin/conf/log4j2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,19 @@
</Appenders>

<Loggers>
<logger name="amoro.metric" level="info">
<logger name="amoro.metric" level="info" additivity="false">
<!-- iceberg rest metric reporter logs -->
<AppenderRef ref="amoroMetricReporter" />
<AppenderRef ref="amoroMetricReporter"/>
</logger>

<logger name="org.apache.spark" level="warn" additivity="false">
<AppenderRef ref="infoFileAppender"/>
<AppenderRef ref="consoleAppender" level="${CONSOLE_LEVEL}"/>
</logger>

<Root level="debug">
<!--By default, debug logs are not printed-->
<!-- <AppenderRef ref="debugFileAppender" level="debug"/>-->
<!--<AppenderRef ref="debugFileAppender" level="debug"/>-->
<AppenderRef ref="infoFileAppender" level="info"/>
<AppenderRef ref="errorFileAppender" level="error"/>
<!-- SET CONSOLE_LOG_LEVEL=info to print console logger in docker -->
Expand Down