Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Copy catalog meta for outside usage #3433

Merged

Conversation

zhoujinsong
Copy link
Contributor

Why are the changes needed?

Copy catalog meta for outside usage to prevent unexpected change.

Brief change log

  • As titled.

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@zhoujinsong zhoujinsong requested a review from baiyangtx February 7, 2025 09:20
@github-actions github-actions bot added the module:ams-server Ams server module label Feb 7, 2025
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoujinsong zhoujinsong merged commit ff1fe3f into apache:master Feb 8, 2025
4 checks passed
@zhoujinsong zhoujinsong deleted the Fix-catalog-meta-change-issue branch February 8, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:ams-server Ams server module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants