Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMORO-3348] Extract the implementation of OptimizerManager #3437

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

mansonliwh
Copy link
Contributor

@mansonliwh mansonliwh commented Feb 14, 2025

Why are the changes needed?

close #3438 .

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are welcomed to contribute to the project by contributing code. Generally speaking, there are no major issues with this PR. However, some implementation details can be optimized. I have left some comments. Please check them.

@mansonliwh mansonliwh force-pushed the stateless-optimizer-manager branch from 03ecbb3 to e127d7d Compare February 17, 2025 07:47
@mansonliwh mansonliwh changed the title draft:[AMORO-3346] Extract the implementation of OptimizerManager [AMORO-3348] Extract the implementation of OptimizerManager Feb 17, 2025
@mansonliwh mansonliwh requested a review from baiyangtx February 18, 2025 01:59
@mansonliwh mansonliwh requested a review from czy006 February 18, 2025 06:43
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

@baiyangtx baiyangtx merged commit 7c43e75 into apache:master Feb 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]: Extract the implementation of OptimizerManager
3 participants