Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: login bg displayed imcompletely #1026

Closed
wants to merge 1 commit into from

Conversation

liuxiran
Copy link
Contributor

Please answer these questions before submitting a pull request

  • Why submit this pull request?
  • Bugfix
  • New feature provided
  • Improve performance

Bugfix

  • Description
    current login page’s background(update dashboard to master) displayed imcompletely:

2020-12-11 21-41-56屏幕截图

  • How to fix?

updated less files.

@juzhiyuan juzhiyuan requested a review from LiteSun December 11, 2020 14:25
@LiteSun
Copy link
Member

LiteSun commented Dec 14, 2020

This background issue is not reproduced in my local environment (latest master branch code), could you please provide more information? @liuxiran
image

@liuxiran
Copy link
Contributor Author

This background issue is not reproduced in my local environment (latest master branch code), could you please provide more information? @liuxiran
image

After I rm node_modules and reinstall node dependences, this page looks ok now.

after compared the difference between the two, I found that:
currently the login component is rendering undering pro-basicLayout
mmexport1607922392820

while the page in the issue is rendering itself

mmexport1607922364748

It may be caused by the package version, and I could not reproduce it now.

close this pr when it can be reproduced, I'll reopen it again.

@liuxiran liuxiran closed this Dec 14, 2020
@liuxiran liuxiran mentioned this pull request Dec 15, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants