Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FE): skip Cypress binary install when build #1248

Merged
merged 1 commit into from
Jan 8, 2021
Merged

feat(FE): skip Cypress binary install when build #1248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test-frontend-multiple-node-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
# Install dependencies
- name: Install dependencies
working-directory: web
run: yarn
run: CYPRESS_INSTALL_BINARY=0 yarn

- name: Lint
working-directory: web
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ help:
### build: Build Apache APISIX Dashboard, it contains web and manager-api
.PHONY: build
build: web-default api-default
api/build.sh && cd ./web && export PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true && yarn install && yarn build && mkdir -p ../output/logs
api/build.sh && cd ./web && export CYPRESS_INSTALL_BINARY=0 && yarn install && yarn build && mkdir -p ../output/logs


.PHONY: web-default
Expand Down