-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scheme field test case #1661
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1661 +/- ##
==========================================
+ Coverage 71.35% 71.80% +0.44%
==========================================
Files 47 47
Lines 3128 3128
==========================================
+ Hits 2232 2246 +14
+ Misses 656 639 -17
- Partials 240 243 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cc @guoqqqi to take a look |
also cc @guoqqqi to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ci failed, please take a look: https://github.com/apache/apisix-dashboard/pull/1661/checks?check_run_id=2301814384#step:10:798 |
name="scheme" | ||
> | ||
<Select disabled={readonly}> | ||
{['http', 'https', 'grpc', 'grpcs'].map((item, index) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never done .tsx
before. I have done one other .tsx
review. So similar my view is that an array or list should be ordered somehow and mostly its done alphabetically. I always like rules, standards and style guides.
{['http', 'https', 'grpc', 'grpcs'].map((item, index) => ( | |
{['grpc', 'grpcs', 'http', 'https'].map((item, index) => ( |
Deploy preview for apisix-dashboard ready! Built with commit ec569b1 |
I know what happened, one PR needs to be fixed. |
just wait for fixing it 😂 |
@batman-ezio maybe you could sync code from master to try to fix FE CI |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the [email protected] list. Thank you for your contributions. |
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
add an optional field scheme on the upstream form
Related issues
fix/resolve #1642
Checklist: