-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add how to integrate with grafana preview link #1697
Conversation
Precautions for configuring grafana.
Add FAQ. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thanks a lot, and there have some minor changes that would make this PR better.
Hi @wgy-home, I noticed there have some lint errors, would you like to fix them? |
✔️ Deploy Preview for apisix-dashboard ready! 🔨 Explore the source changes: a1dd844 🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6124ba2e56b044000716efd9 😎 Browse the preview: https://deploy-preview-1697--apisix-dashboard.netlify.app/ |
Hey @wgy-home could you please follow semantic format for PR title. |
```shell | ||
# grep 'allow_embedding' defaults.ini | ||
allow_embedding = true | ||
··· |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should enable cors
in grafana config?
By the way, I think you should change the title of this PR. |
Precautions for configuring grafana.
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
fix #1699
Please update this section with detailed description.
Related issues
fix/resolve #1
Checklist: