Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add how to integrate with grafana preview link #1697

Merged
merged 9 commits into from
Aug 30, 2021

Conversation

wgy-home
Copy link
Contributor

@wgy-home wgy-home commented Mar 31, 2021

Precautions for configuring grafana.

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

fix #1699

Please update this section with detailed description.

Related issues

fix/resolve #1

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Precautions for configuring grafana.
@wgy-home
Copy link
Contributor Author

Add FAQ.

Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Thanks a lot, and there have some minor changes that would make this PR better.

@juzhiyuan
Copy link
Member

Hi @wgy-home, I noticed there have some lint errors, would you like to fix them?

image

@netlify
Copy link

netlify bot commented Aug 10, 2021

✔️ Deploy Preview for apisix-dashboard ready!

🔨 Explore the source changes: a1dd844

🔍 Inspect the deploy log: https://app.netlify.com/sites/apisix-dashboard/deploys/6124ba2e56b044000716efd9

😎 Browse the preview: https://deploy-preview-1697--apisix-dashboard.netlify.app/

@liuxiran liuxiran requested review from bzp2010 and LiteSun August 24, 2021 09:11
@iamayushdas
Copy link
Contributor

Hey @wgy-home could you please follow semantic format for PR title.
docs: "your pr title"
Thanks for contributing

```shell
# grep 'allow_embedding' defaults.ini
allow_embedding = true
···
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should enable cors in grafana config?

@starsz
Copy link
Contributor

starsz commented Aug 30, 2021

By the way, I think you should change the title of this PR.

@juzhiyuan juzhiyuan changed the title How to add grafana docs: add how to integrate with grafana preview link Aug 30, 2021
@juzhiyuan juzhiyuan merged commit bcdd3b6 into apache:master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

after configuring the Grafana address in Metrics, the page cannot be displayed normally
6 participants