feat: support protobuf on Web #2320
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2320 +/- ##
==========================================
+ Coverage 68.07% 68.52% +0.45%
==========================================
Files 128 131 +3
Lines 3358 3419 +61
Branches 822 826 +4
==========================================
+ Hits 2286 2343 +57
- Misses 1072 1076 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
cc @Baoyuantop @guoqqqi to have a review |
|
@guoqqqi @Baoyuantop Please help me review.😃 |
web/cypress/integration/proto/create_and_edit_and_delete_proto.spce.js
Outdated
Show resolved
Hide resolved
|
@LiteSun Please help me re execute CI. I can pass it in the development environment. |
web/src/pages/Proto/List.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| const { page = 1, pageSize = 10 } = querystring.parse(window.location.search); | ||
| setPaginationConfig({ pageSize: Number(pageSize), current: Number(page) }); |
There was a problem hiding this comment.
How about using your usepagination? (we could merge that one first)
|
@juzhiyuan @bzp2010 Please help me re execute CI. I can pass it in the development environment. |
|
LGTM with the screenshots and test cases. BTW, do we have a plan to support selecting proto on the UI of the plugin |
web/src/pages/Proto/locales/en-US.ts
Outdated
| export default { | ||
| 'page.proto.list': 'Proto List', | ||
| 'page.proto.list.description': | ||
| "Protocol buffers are Google's language-neutral, platform-neutral, extensible mechanism for serializing structured data.You define how you want your data to be structured once, then you can use special generated source code to easily write and read your structured data to and from a variety of data streams and using a variety of languages.", |
There was a problem hiding this comment.
The relationship between the proto and the grpc-transcode plugin needs to be explained.
There was a problem hiding this comment.
There was a problem hiding this comment.
Hi @oil-oil , we must explain that the proto resources here are used in the grpc-transcode plugin and that the proto resources created here can be accessed by selecting the corresponding IDs when the grpc-transcode plugin is opened. There is no need to explain what Protocol buffers are.
There was a problem hiding this comment.
@oil-oil I see your update. LGTM, but should be better to keep the previous introduction.
You can create a new issue after the current PR is merged, Maybe I'll try to develop it. 😀 |
|
@Baoyuantop please have a look again. |
web/src/pages/Proto/locales/zh-CN.ts
Outdated
| export default { | ||
| 'page.proto.list': 'Proto 列表', | ||
| 'page.proto.list.description': | ||
| 'Protocol Buffers 是 Google 用于序列化结构化数据的框架，它具有语言中立、平台中立、可扩展机制的特性，您只需定义一次数据的结构化方式，然后就可以使用各种语言通过特殊生成的源代码轻松地将结构化数据写入和读取各种数据流。', |
* origin: feat: release 2.11.0 (apache#2361) feat: add data loader framework (apache#2371) feat: improve Consumer module (apache#2327) fix: ! (reverse) operator not handled correctly (apache#2364) chore: modify the select upstream field to upstream (apache#2344) feat: support protobuf on Web (apache#2320) chore: Extract paging related functions into standalone hook (apache#2334) feat: basic support Apache APISIX 2.12.1 (apache#2315) # Conflicts: # web/src/helpers.tsx # web/yarn.lock
Please answer these questions before submitting a pull request, or your PR will get closed.
Why submit this pull request?
What changes will this PR take into?
I added a page to manage protos for the apisix dashboard. In order to support the monaco editor to prompt the proto file code, I upgraded its version .
List page:
Edit page:
Related issues
resolve #2189
Checklist: