Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate ID #2501

Merged
merged 3 commits into from
Jul 7, 2022
Merged

fix: duplicate ID #2501

merged 3 commits into from
Jul 7, 2022

Conversation

SkyeYoung
Copy link
Member

Please answer these questions before submitting a pull request, or your PR will get closed.

Why submit this pull request?

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What changes will this PR take into?

Remove ID when copying routes.

Related issues

fix #2407

Checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

Codecov Report

Merging #2501 (cc28a6e) into master (4e1acf0) will increase coverage by 0.05%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #2501      +/-   ##
==========================================
+ Coverage   68.52%   68.58%   +0.05%     
==========================================
  Files         133      133              
  Lines        3498     3501       +3     
  Branches      860      861       +1     
==========================================
+ Hits         2397     2401       +4     
+ Misses       1101     1100       -1     
Flag Coverage Δ
frontend-e2e-test 68.58% <75.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/pages/Route/Create.tsx 83.33% <75.00%> (-0.41%) ⬇️
web/src/helpers.tsx 73.77% <0.00%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36f1ba9...cc28a6e. Read the comment docs.

@juzhiyuan juzhiyuan merged commit 5f44089 into apache:master Jul 7, 2022
bzp2010 pushed a commit to bzp2010/apisix-dashboard that referenced this pull request Jul 13, 2022
(cherry picked from commit 5f44089)
hongbinhsu pushed a commit to fitphp/apix-dashboard that referenced this pull request Sep 10, 2022
* upstream/master: (23 commits)
  feat: Add config struct of OpenID-Connect Login (apache#2597)
  feat: set serverUrlMap with env, update cypress, update stylelint (apache#2583)
  chore: fix function name typo (apache#2599)
  fix: page refresh causes deletion exception (apache#2593)
  feat: support show all enable plugin list tab (apache#2585)
  fix: drawer components delete plugin not working (apache#2573)
  feat: add batch delete function for route (apache#2502)
  test: reduce fe ci time (apache#2557)
  doc(csp): add correct csp rule (apache#2548)
  doc: add a notice about the compatibility of Ingress and Dashboard (apache#2552)
  fix: add judgement for last_report_time (apache#2551)
  fix: cli test invalid etcd (apache#2544)
  feat: fix actions version to root version (apache#2521)
  fix: duplicate ID (apache#2501)
  fix: block arbitrary file index (apache#2497)
  docs: update deploy-with-docker.md (apache#2472)
  feat: translating Turkish for new features (apache#2487)
  docs: add new import and export docs to sidebar (apache#2485)
  docs: add data loader and new OpenAPI 3 loader (apache#2484)
  feat: support data loader in frontend (apache#2480)
  ...

# Conflicts:
#	api/internal/route.go
#	web/config/defaultSettings.ts
#	web/yarn.lock
bzp2010 pushed a commit to bzp2010/apisix-dashboard that referenced this pull request Oct 31, 2022
(cherry picked from commit 5f44089)
@SkyeYoung SkyeYoung deleted the fix-issue-2407 branch November 10, 2022 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: The copy function copied the ID, resulting in duplicate ID and unable to submit
4 participants