Feat release 1.5 #356
Feat release 1.5 #356
Conversation
|
@juzhiyuan please avoid pinging all the apache committers (you've pinged 3k+ people) |
Oh no.. I meant to ping only apisix's committers.. |
Hi @juzhiyuan . I'm not a committer on this project, but received the notification along with the other people throughout Apache, and wanted to offer a few friendly tips: You never need to ping any GitHub teams on a PR. That forces a notification to everybody on that team who has linked their GitHub account to their Apache committer account, even if they've specifically elected to not receive notifications for activity on the repository. Those teams are primarily used internally for permissions management, and are not the best way to get the developers' attention. Mentioning a team is also redundant. If somebody has chosen to watch the repository, then they would have received a notification of the new PR anyway, because they have subscribed to those notifications. No additional mention is necessary to trigger a notification. In addition, the developer teams would have also received an email notification for new pull requests on their notification list, such as this one. If you open a pull request and don't hear anything from the developers in a reasonable time, the best practice is probably to try to simply comment on the pull request or reach out to their developer mailing list instead (usually People make mistakes. I'm sure it's not a huge problem, but I hope these tips help in future. |
|
Hi @ctubbsii , your tips would help me to use GitHub more reasonable, thanks a lot! |
|
Because I pinged to the whole Apache committeers by mistake, I have to close this PR. related issue #357 |
@apache/apisix-committers Please take a look, this PR mainly updates Deployment by manually, and added CHANGELOG for V1.5.
Once the PR is approved and merged, I will checkout a branch called v1.5