feat: support watching config changes #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has totally checked 148 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 77 | 2 | 69 | 0 |
Click to see the invalid file list
- runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/TestWatcher.java
- runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/A6ConfigWatcher.java
runner-core/src/test/java/org/apache/apisix/plugin/runner/handler/TestWatcher.java
Show resolved
Hide resolved
runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/A6ConfigWatcher.java
Show resolved
Hide resolved
…ler/TestWatcher.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…r/A6ConfigWatcher.java Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nic-chen
changed the title
tzssangglass
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting a pull request
New feature or improvement
support watching config for filters, so in some scenarios, config can be updated in time instead of only when requests comes.