Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DISCUSS]: allow user to specify APISIX id in config.yaml #2810

Closed
spacewander opened this issue Nov 21, 2020 · 8 comments
Closed

[DISCUSS]: allow user to specify APISIX id in config.yaml #2810

spacewander opened this issue Nov 21, 2020 · 8 comments
Assignees
@tzssangglass
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@spacewander
Copy link
Member

Currently, the id of APISIX is generated UUID, which can't be controlled by the user. I think it would be good to allow user to specify a meaningful id to bind APISIX instance with their internal system.
@tokers
Copy link
Contributor

tokers commented Nov 21, 2020

It would be better to support vars.

@spacewander
Copy link
Member Author

It would be better to support vars.

I am confusing. vars is already supported: #2743

@tokers
Copy link
Contributor

tokers commented Nov 21, 2020

It would be better to support vars.

I am confusing. vars is already supported: #2743

Sorry i forgot it.

@membphis membphis added enhancement New feature or request good first issue Good for newcomers labels Nov 23, 2020
@membphis
Copy link
Member

I think that is a good feature

@tzssangglass
Copy link
Member

Let me try.

@membphis
Copy link
Member

I have assigned this job to you @tzssangglass
good luck ^_^

@tzssangglass
Copy link
Member

I have assigned this job to you @tzssangglass
good luck ^_^

ok

tzssangglass added a commit to tzssangglass/apisix that referenced this issue Nov 29, 2020
@tzssangglass
allow user to specify APISIX id in config.yaml

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
eb03cf9 
fix apache#2810
@tzssangglass tzssangglass mentioned this issue Nov 29, 2020
Merged
4 tasks
@tzssangglass
Copy link
Member

my pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tzssangglass tzssangglass

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@spacewander @membphis @tokers @tzssangglass