-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: proxy-cache plugin has side-effect even if it's not configured in any route #3677
Labels
bug
Something isn't working
Comments
it is not easy to fix this bug, I think it needs to change the Nginx core. |
disable |
Agree, but proxy-cache might be used in some scenarios. The fix might not be available to all users. |
Similar like #3373? |
Yes, seems the same |
Will you submit a fix? I have already provided a solution in that issue. |
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this issue
Mar 9, 2021
Fix apache#3373 Fix apache#3677 Signed-off-by: spacewander <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue description
If proxy-cache is configured in plugin list, it will override Cache-Control and Expires headers from the upstream.
Problem is that even if proxy-cache is not configured in any route, those headers will still be overridden.
So we have a side effect for proxy-cache.
Environment
apisix version
): 2.0uname -a
): linuxnginx -V
oropenresty -V
): openresty/1.19.3.1curl http://127.0.0.1:9090/v1/server_info
to get the info from server-info API):Minimal test code / Steps to reproduce the issue
What's the actual result? (including assertion message & call stack if applicable)
Cache-Control and Expires headers disappeared
What's the expected result?
If proxy-cache is not configured for a route, apisix should not rewrite Cache-Control and Expires headers.
The text was updated successfully, but these errors were encountered: