Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update documentation for multi-auth plugin #10524

Merged
merged 3 commits into from
Nov 21, 2023
Merged

docs: update documentation for multi-auth plugin #10524

merged 3 commits into from
Nov 21, 2023

Conversation

markokocic
Copy link
Contributor

@markokocic markokocic commented Nov 20, 2023 •
edited
Loading

Clarify plugin usage.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@markokocic
Copy link
Contributor Author

@madhawa-gunasekara , can you please verify?

kayx23
kayx23 requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@kayx23 kayx23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix for lint errors, thanks.

@markokocic
Copy link
Contributor Author

Hi @kayx23
I applied your suggestions.

@kayx23
Copy link
Member

kayx23 commented Nov 20, 2023

and the markdownlint error please

@monkeyDluffy6017 monkeyDluffy6017 merged commit a2da5f1 into apache:master Nov 21, 2023
@markokocic markokocic deleted the patch-2 branch November 21, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madhawa-gunasekara madhawa-gunasekara madhawa-gunasekara approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@kayx23 kayx23 kayx23 approved these changes

@shreemaan-abhishek shreemaan-abhishek Awaiting requested review from shreemaan-abhishek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markokocic @kayx23 @madhawa-gunasekara @monkeyDluffy6017