Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test/cli): wait for control API to be available #10539

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix(test/cli): wait for control API to be available #10539

merged 2 commits into from
Nov 24, 2023

Conversation

shreemaan-abhishek
Copy link
Contributor

Description

This fixes the recurring failure for CLI test CI.

image
https://github.com/apache/apisix/actions/runs/6958424012/job/18933398871?pr=10425

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek shreemaan-abhishek marked this pull request as draft November 23, 2023 12:16
@shreemaan-abhishek
Copy link
Contributor Author

shreemaan-abhishek commented Nov 23, 2023 •
edited
Loading

to be merged after #10542

@shreemaan-abhishek shreemaan-abhishek changed the title fix(test/cli): wait for control plane to be available fix(test/cli): wait for control API to be available Nov 23, 2023
@shreemaan-abhishek shreemaan-abhishek marked this pull request as ready for review November 23, 2023 14:13
@monkeyDluffy6017 monkeyDluffy6017 merged commit 0596eb2 into apache:master Nov 24, 2023
@shreemaan-abhishek shreemaan-abhishek deleted the fix/cli-test-ci branch November 24, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sn0rt Sn0rt Sn0rt approved these changes

@monkeyDluffy6017 monkeyDluffy6017 monkeyDluffy6017 approved these changes

@AlinsRan AlinsRan AlinsRan approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shreemaan-abhishek @Sn0rt @monkeyDluffy6017 @AlinsRan