fix: multi-auth raise 500 error when use default conf #11145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please also add test cases |
|
done, pls check again. |
| @@ -54,6 +54,10 @@ function _M.check_schema(conf) | |||
| if auth.type ~= 'auth' then | |||
| return false, auth_plugin_name .. " plugin is not supported" | |||
| end | |||
| local ok, err = auth.check_schema(auth_plugin_conf, auth.schema) | |||
| if not ok then | |||
| return false, "plugin " .. auth_plugin_name .. " check schema failed: " .. err | |||
There was a problem hiding this comment.
can you also add a test case which shows this error would be raised if any auth_plugin has wrong configuration.
There was a problem hiding this comment.
perfect, really appreciate it <3. I will re-review once the CI has completed running.
moonming
approved these changes
Apr 24, 2024
starsz
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #11156
Related: #9893
Checklist