Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use interceptors to protect plugin's route #2416

Merged
merged 4 commits into from
Oct 17, 2020
Merged

feat: use interceptors to protect plugin's route #2416

merged 4 commits into from
Oct 17, 2020

Conversation

spacewander
Copy link
Member

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

TODO: add doc

juzhiyuan
juzhiyuan approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from codes style

membphis
membphis approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@membphis membphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR. Good design and implementation.

@spacewander spacewander merged commit 6a543a9 into apache:master Oct 17, 2020
@moonming moonming added this to the 2.0 milestone Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@membphis membphis membphis approved these changes

@juzhiyuan juzhiyuan juzhiyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spacewander @juzhiyuan @membphis @moonming