Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: authz-keycloak plugin should not be marked as auth-type and should run in access phase, basic-auth plugin should run in rewrite phase. #2859

Closed
wants to merge 9 commits into from
+10 −4
Closed

fix: authz-keycloak plugin should not be marked as auth-type and should run in access phase, basic-auth plugin should run in rewrite phase. #2859

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
cc3f2c0
fix: Make plugin run in access phase. (#2857)
jenskeiner Nov 26, 2020
3ad3a20
docs: Reflect that authentication/authorization should be done in acc…
jenskeiner Nov 26, 2020
aea636e
Make all authentication plugins run in rewrite phase. Don't designate…
jenskeiner Nov 27, 2020
fa061ee
Revert previous change to restore that authentication plugins should …
jenskeiner Nov 30, 2020
1ee7cd4
Add debug code to log consumer.
jenskeiner Nov 30, 2020
cc46bc0
Add missing config for test case.
jenskeiner Nov 30, 2020
e88f887
Wrap line.
jenskeiner Nov 30, 2020
ac84f84
Change log level.
jenskeiner Nov 30, 2020
cccaf75
Use debug log level again.
jenskeiner Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Wrap line.
@jenskeiner
jenskeiner committed Nov 30, 2020
commit e88f887cef167294667d5631598152f201ce9ee8
3 changes: 2 additions & 1 deletion apisix/init.lua
View file
Original file line number Diff line number Diff line change
@@ -513,7 +513,8 @@ function _M.http_access_phase()
api_ctx.consumer,
api_ctx
)
core.log.debug("find consumer ", api_ctx.consumer.username, ", config changed: ", changed)
core.log.debug("find consumer ", api_ctx.consumer.username,
", config changed: ", changed)
if changed then
core.table.clear(api_ctx.plugins)
api_ctx.plugins = plugin.filter(route, api_ctx.plugins)