Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream dns resolver failed response 503 #3398

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

syzh
Copy link
Contributor

@syzh syzh commented Jan 23, 2021

fixed issue #3342.

@spacewander
Copy link
Member

Need to update the tests.

@syzh
Copy link
Contributor Author

syzh commented Jan 25, 2021

Need to update the tests.

I need some time to add more tests case

@spacewander
Copy link
Member

@syzh
You just need to update the expected status code in the tests.

@Firstsawyou
Copy link
Contributor

Hi, @syzh

You need to update the test case to solve the problem of ci failure.

For example: TEST 8 of the upstream2.t test case, you need to change 502 to 503.

#   Failed test 'TEST 8: hit empty nodes upstream - status code ok'
#   at /home/runner/work/apisix/apisix/test-nginx/lib/Test/Nginx/Socket.pm line 935.
#          got: '503'
#     expected: '502'
# Looks like you failed 1 test of 30.
t/admin/upstream2.t ....................... 
Dubious, test returned 1 (wstat 256, 0x100)

@membphis
Copy link
Member

ping @syzh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants