Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added uniform id from apisix doc #4474

Closed
wants to merge 1 commit into from

Conversation

iamayushdas
Copy link
Contributor

What this PR does / why we need it:

uniform/particular id given to the documentation

issue: apache/apisix-website#363

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@@ -21,7 +21,7 @@ title: Getting Started
#
-->

## Getting Started
## Getting Started {#apisix}
Copy link
Member

@spacewander spacewander Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the render in the GitHub markdown preview (maybe also the cross reference). Can we add the mark into <!-- --> and take it away from the title?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we can't do that, and i have tested this on my system it works fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not the title , the title is above the license text

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamayushdas I suggest submitting PRs on one repo for test & preview, let's have a preview here apache/apisix-dashboard#1951 first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the title from the view of the markdown version. See https://github.com/apache/apisix/blob/master/docs/en/latest/getting-started.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't accept such a scar on the title. The solution is quite a hack. How can a mark be put into the content, especially the content is obvious to everyone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spacewander Sir, first of all I am extremely sorry flooding PRs without discussing,
My PROPOSAL:
Docusaurus has opted this way for adding id's to be more precise. they have changed the md style in such a way that we can add precise id without harming our website
reference md file - https://github.com/facebook/docusaurus/blob/master/website/docs/api/plugins/plugin-content-blog.md
screenshot:
image

website created from above md file: https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-blog
screenshot:
https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-blog
Screenshot 2021-06-24 at 3 55 22 PM

now please visit this issue: apache/apisix-website#363

@spacewander
Copy link
Member

I am quite annoyed by
#4476
#4477

Feel free to reopen it if you find a way to add mark without:

  1. adding visible mark on the title
  2. breaking the cross-reference among markdowns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants