-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add additional option to control the default_conn_delay option of the limit-conn plugin #4604
Merged
spacewander
merged 22 commits into
apache:master
from
zuiyangqingzhou:optimize_conn_delay
Jul 22, 2021
Merged
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
344701b
修复多个request-id产生的bug
zuiyangqingzhou 18e2ded
Merge branch 'fix-request-id'
zuiyangqingzhou fe7df38
Merge branch 'apache:master' into master
zuiyangqingzhou ffe870e
1、request-id add prefix
zuiyangqingzhou 9e02e21
Merge branch 'fix-request-id'
zuiyangqingzhou 6f1efed
remove unnecessary logic
zuiyangqingzhou cdb3798
Merge branch 'fix-request-id'
zuiyangqingzhou 2489318
fix the linter
zuiyangqingzhou 83ef3f3
Merge branch 'apache:master' into master
zuiyangqingzhou 08fef26
Merge branch 'fix-request-id'
zuiyangqingzhou c48ac1b
Merge branch 'apache:master' into master
zuiyangqingzhou e6ea846
Merge branch 'apache:master' into master
zuiyangqingzhou 4a58f9c
Merge branch 'apache:master' into master
zuiyangqingzhou 753a956
add additional option to control the default_conn_delay parameter
zuiyangqingzhou abfa56c
adjustment format
zuiyangqingzhou c54d2bc
adjustment format
zuiyangqingzhou 3d3f9d5
Merge branch 'apache:master' into master
zuiyangqingzhou ba19219
Merge branch 'master' into optimize_conn_delay
zuiyangqingzhou 0ee8e03
add test cases
zuiyangqingzhou 00d716c
fix code style error
zuiyangqingzhou 47dc329
fix code style error
zuiyangqingzhou bdedb6c
fix log phase conf param error
zuiyangqingzhou File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the option name is not so straightforward but I didn't come out with a more proper one :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about
only_use_default_delay
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only_use_default_delay
,use_default_conn_delay
,apply_default_conn_delay
,stint_default_conn_delay
, Which of the four do you think is better, or do you have better suggestions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for the first one. What about others' opinions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tokers what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vote for the first one too, it's easy to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I will change it to this one.
What about the test case I mentioned above? Any suggestions? @spacewander @tokers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can take a look at the test in #4585