feat: add rizhiyi logger #8265
feat: add rizhiyi logger #8265
Conversation
|
Please add test cases and documentation. |
| local batch_processor_manager = bp_manager_mod.new(plugin_name) | ||
|
|
||
| ---calc pri--- | ||
| local Facility = { |
There was a problem hiding this comment.
Is there any doc for rizhiyi's log format?
There was a problem hiding this comment.
日志易可以接收多种格式的日志并自动解析，当前这个插件是基于syslog日志格式开发的
Just curious, can we use the existing syslog plugin to push logs to rizhiyi?
There was a problem hiding this comment.
如果syslog插件支持定义syslog的元数据格式和内容
we can also set the format of the logs by configuring the Plugin metadata , ref: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/sls-logger.md#metadata
Even though the syslog documentation doesn't say so, it should be supported and used the same way. You can help to verify it.
There was a problem hiding this comment.
我说的元数据指的是粗体的部分，插件的元数据指的的是非粗体的部分(如果我没理解错的话)。
So can we develop the existing syslog plugin and add configuration to make it support rizhiyi?
There was a problem hiding this comment.
Even though the syslog documentation doesn't say so, it should be supported and used the same way. You can help to verify it.
fix: not yet supported, waiting for #8279
There was a problem hiding this comment.
不会，因为新插件已经开发完了。。你看这种情况是怎么处理，是等syslog插件的新功能吗，还是先使用这个插件？It's up to you！！
IMO, you can wait for the #8279 merg, and add custom log format support on syslog to make log-util generated logs conform to a specific format, such as rizhiyi.
There was a problem hiding this comment.
can we merge this PR?
Not. Reason: According to the discussion above, this feature does not require a new plugin, just need to make syslog support rizhiyi.
There was a problem hiding this comment.
Great. @mcy567 do you have time to continue this plugin?
Description
添加日志易logger
Checklist