-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(makefile): add PCRE_INCDIR variable #8433
Conversation
I have tested with Linux and Darwin:
Finally both linux and darwin install jsonschema(requeir |
I am not sure why the CI job build (ubuntu-20.04, linux_openresty_1_19, t/plugin/[a-k]*) succeeded but build (ubuntu-20.04, linux_openresty, t/plugin/[a-k]*) failed.And I think the difference of the two job is the openresty version. |
the failed CI |
hi @drgnchan I think you are mistaken, your PR has other people's commits in it. |
pls follow the git follow: https://apisix.apache.org/docs/general/contributor-guide/#create-your-branch |
@tzssangglass I am sorry having made the wrong workflow before.I just sync fork by Github and I think it is ok now. |
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
LGTM the branch has been tested at a M2 machine. |
@Sn0rt Thanks |
Description
Fixes #8432
Checklist