address comments

apache · Nov 23, 2022 · 40a4ee3 · 40a4ee3
1 parent 368920b
commit 40a4ee3
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 17 deletions.
diff --git a/arrow/Cargo.toml b/arrow/Cargo.toml
@@ -53,7 +53,6 @@ arrow-ipc = { version = "27.0.0", path = "../arrow-ipc", optional = true }
 arrow-json = { version = "27.0.0", path = "../arrow-json", optional = true }
 arrow-schema = { version = "27.0.0", path = "../arrow-schema" }
 arrow-select = { version = "27.0.0", path = "../arrow-select" }
-parquet = { version = "27.0.0", path = "../parquet", features = ["arrow", "async"]}
 rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional = true }
 num = { version = "0.4", default-features = false, features = ["std"] }
 half = { version = "2.1", default-features = false, features = ["num-traits"] }
@@ -66,8 +65,6 @@ comfy-table = { version = "6.0", optional = true, default-features = false }
 pyo3 = { version = "0.17", default-features = false, optional = true }
 multiversion = { version = "0.6.1", default-features = false }
 bitflags = { version = "1.2.1", default-features = false, optional = true }
-tokio = { version = "1.22.0", features = ["full"] }
-futures = "0.3.25"
 
 [package.metadata.docs.rs]
 features = ["prettyprint", "ipc_compression", "dyn_cmp_dict", "ffi", "pyarrow"]
@@ -123,16 +120,6 @@ name = "read_csv_infer_schema"
 required-features = ["prettyprint", "csv"]
 path = "./examples/read_csv_infer_schema.rs"
 
-[[example]]
-name = "read_parquet"
-required-features = ["prettyprint"]
-path = "./examples/read_parquet.rs"
-
-[[example]]
-name = "async_read_parquet"
-required-features = ["prettyprint"]
-path = "./examples/async_read_parquet.rs"
-
 [[bench]]
 name = "aggregate_kernels"
 harness = false

diff --git a/parquet/Cargo.toml b/parquet/Cargo.toml
@@ -128,3 +128,14 @@ harness = false
 
 [lib]
 bench = false
+
+[build-dependencies]
+
+[[example]]
+name = "read_parquet"
+path = "./examples/read_parquet.rs"
+
+[[example]]
+name = "async_read_parquet"
+required-features = ["arrow", "async"]
+path = "./examples/async_read_parquet.rs"
diff --git a/arrow/examples/async_read_parquet.rs → parquet/examples/async_read_parquet.rs b/arrow/examples/async_read_parquet.rs → parquet/examples/async_read_parquet.rs
@@ -15,8 +15,6 @@
 // specific language governing permissions and limitations
 // under the License.
 
-extern crate arrow;
-
 use arrow::util::pretty::print_batches;
 use futures::TryStreamExt;
 use parquet::arrow::arrow_reader::{ArrowPredicate, RowFilter};
@@ -25,7 +23,7 @@ use parquet::errors::Result;
 use std::time::SystemTime;
 use tokio::fs::File;
 
-#[tokio::main]
+#[tokio::main(flavor="current_thread")]
 async fn main() -> Result<()> {
     // Create parquet file that will be read.
     let testdata = arrow::util::test_util::parquet_test_data();

diff --git a/arrow/examples/read_parquet.rs → parquet/examples/read_parquet.rs b/arrow/examples/read_parquet.rs → parquet/examples/read_parquet.rs
@@ -16,7 +16,7 @@
 // under the License.
 
 use arrow::util::pretty::print_batches;
-use parquet::arrow::arrow_reader::{ArrowReaderOptions, ParquetRecordBatchReaderBuilder};
+use parquet::arrow::arrow_reader::ParquetRecordBatchReaderBuilder;
 use parquet::errors::Result;
 use std::fs::File;