-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split up arrow::array::builder
module
#1843
Labels
arrow
Changes to the arrow crate
enhancement
Any new improvement worthy of a entry in the changelog
good first issue
Good for newcomers
help wanted
Comments
tustvold
added
good first issue
Good for newcomers
enhancement
Any new improvement worthy of a entry in the changelog
help wanted
labels
Jun 10, 2022
This was referenced Jun 11, 2022
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 15, 2022
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 15, 2022
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 15, 2022
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 15, 2022
- Removed old builder.rs - Added missing licensing header to builder submodules - Updated builder submodule imports and exports - Updated array mod file builder imports and exports
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 16, 2022
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 16, 2022
- Removed old builder.rs - Added missing licensing header to builder submodules - Updated builder submodule imports and exports - Updated array mod file builder imports and exports
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 16, 2022
DaltonModlin
added a commit
to DaltonModlin/arrow-rs
that referenced
this issue
Jun 16, 2022
- Removed old builder.rs - Added missing licensing header to builder submodules - Updated builder submodule imports and exports - Updated array mod file builder imports and exports
alamb
changed the title
Split up arrow::array::builder module
Split up Jun 23, 2022
arrow::array::builder
module
tustvold
added a commit
to tustvold/arrow-rs
that referenced
this issue
Jun 23, 2022
tustvold
added a commit
that referenced
this issue
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arrow
Changes to the arrow crate
enhancement
Any new improvement worthy of a entry in the changelog
good first issue
Good for newcomers
help wanted
Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The arrow::array::builder module is implemented as one immense builder.rs file, this has a number of drawbacks:
Describe the solution you'd like
I would like to split out the various builders from
builder.rs
into their own submodules, e.g.The top-level
builder/mod.rs
can then re-export each of these withpub use
to avoid introducing breaking changes.Describe alternatives you've considered
We could not do this
The text was updated successfully, but these errors were encountered: